Skip to content

annotations appears twice #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue Dec 7, 2022 · 7 comments · Fixed by #3268
Closed

annotations appears twice #3265

Hixie opened this issue Dec 7, 2022 · 7 comments · Fixed by #3268
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@Hixie
Copy link
Contributor

Hixie commented Dec 7, 2022

e.g. https://master-api.flutter.dev/flutter/painting/Decoration/lerpFrom.html:

2022-12-06-164445_904x369_scrot

@srawlins
Copy link
Member

srawlins commented Dec 7, 2022

Widget.createElement looks pretty wild too. https://master-api.flutter.dev/flutter/widgets/Widget/createElement.html

This might be only for functions. The bug does not happen in mockito's deferToDefaultResponse, but does happen in observable's observed.

@srawlins srawlins changed the title @protected appears twice annotations appears twice Dec 7, 2022
@srawlins srawlins added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P1 A high priority bug; for example, a single project is unusable or has many test failures labels Dec 7, 2022
@srawlins
Copy link
Member

srawlins commented Dec 8, 2022

Note that this bug is already live at api.flutter.dev: https://api.flutter.dev/flutter/widgets/Widget/createElement.html

Still haven't found what caused the regression.

@srawlins
Copy link
Member

srawlins commented Dec 9, 2022

This bug seems to have been introduced before 66e11fd (2022-01-16). I'm not going to search back before then.

@parlough
Copy link
Member

parlough commented Dec 9, 2022

I guess it's likely #2600 which includes annotations as features, which are rendered, but annotations are still rendered as well.

I'm not sure the intended distinction between features and annotations, but I guess it makes sense for annotations to be rendered above the element description.

@srawlins
Copy link
Member

srawlins commented Dec 9, 2022

Yeah I'm making a change which effectively does that, and adding testing, haha.

@srawlins
Copy link
Member

Another screenshot of the broken code for posterity:

Screen Shot 2022-12-13 at 10 25 24 AM

found at https://pub.dev/documentation/observable/latest/observable/Observable/observed.html

@srawlins
Copy link
Member

If Flutter is keen on having this fix, it is found in dartdoc 6.1.5, cc @goderbauer @gspencergoog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants