Remove annotations from the features section of each element #3268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3265
There is a lot of cruft around the templates but here is the gist:
model_element.dart
,features
used to contain both "features" likecovariant
,read-only
, etc, and annotations. As our annotations have grown, these really should be separated. I remove annotations from features. They should not be included in this collection._annotations
partial to_container_annotations
. This partial was only used for containers, which list annotations in their relationships section (implementors etc), and uses different HTML from the other annotation lists._annotations
partial for non-container annotation lists._accessor_getter
,_accessor_setter
,property
, andtop_level_property
templates, add a render for_annotations
.