Skip to content

Add support for type arguments on annotations #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcollins-g opened this issue Feb 9, 2021 · 3 comments · Fixed by #2600
Closed

Add support for type arguments on annotations #2516

jcollins-g opened this issue Feb 9, 2021 · 3 comments · Fixed by #2600
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug

Comments

@jcollins-g
Copy link
Contributor

Blocks dart-lang/sdk#44922.

Implement dart-lang/language#1297 for dartdoc once analyzer support is available.
@jcollins-g jcollins-g added type-enhancement A request for a change that isn't a bug P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 9, 2021
@jcollins-g jcollins-g mentioned this issue Feb 9, 2021
Closed
3 tasks
@jcollins-g jcollins-g added the status-blocked Blocked from making progress by another (referenced) issue label Feb 9, 2021
@jcollins-g
Copy link
Contributor Author

Blocked on dart-lang/sdk#44838.

@jcollins-g jcollins-g removed the status-blocked Blocked from making progress by another (referenced) issue label Mar 19, 2021
@jcollins-g
Copy link
Contributor Author

This is no longer blocked. A quick smoke test of some files out of the language tests directory suggests we are already past the point of crashing when these are encountered. We are not correctly linking the type parameters, however, so that will need to be done.

@jcollins-g jcollins-g mentioned this issue Apr 1, 2021
Merged
@jcollins-g
Copy link
Contributor Author

#2600 will land the implementation of type parameter linkage inside annotations; a publish and roll into the SDK should make this work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major refactor of dartdoc "features" and annotations jcollins-g/dartdoc
1 participant
@jcollins-g