Simplify logic in features rendering. #2595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default template calls `featuresAsString` twice, once to see if it is empty, then again to render the poor String. `featuresAsString` involves: 1. Iterating over all annotations, 2. finding canonical elements, 3. HTML-escaping the source of each one, 4. sorting the results into a list, by a custom sort. This change introduces a new `hasFeatures` getter. Using this in templates: 1. avoids HTML-escaping, 2. avoids sorting, 3. short-circuits annotations if the element is `final` or `late`, 4. returns `true` when the first displayable element is found, sometimes avoiding iterating. Additionally, the HtmlEscape is extracted into a static const. A `realElement` getter is introduced on ElementAnnotation, which is used in a number of places. Annotations are not HTML-escaped unless we definitely want to display them.
|
Closing; superceded by #2600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default template calls
featuresAsStringtwice, once to see if it is empty, then again to render the poor String.featuresAsStringinvolves:This change switches to just use the
featuresgetter. Using this in templates avoids creating a List and sorting with a custom sort.realElementgetter is introduced on ElementAnnotation, which is used in a number of places.