Skip to content

index.json contains duplicate entries #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chalin opened this issue Jul 12, 2016 · 1 comment
Open

index.json contains duplicate entries #1197

chalin opened this issue Jul 12, 2016 · 1 comment
Labels
area-output-size Issues related to dartdoc's sometimes unreasonable output size. customer-google3 Issues originating from or important to Angular P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-performance Issues related to slow dartdoc generation.

Comments

@chalin
Copy link
Contributor

chalin commented Jul 12, 2016

In applying dartdoc to Angular 2 code (beta.17), the generated index.json contains 124 duplicate entries. Here is one example of a repeated entry:

    {
        "name": "hashCode",
        "qualifiedName": "server.Html5LibDomAdapter.hashCode",
        "href": "server/Html5LibDomAdapter/hashCode.html",
        "type": "property",
        "enclosedBy": {
            "name": "Html5LibDomAdapter",
            "type": "class"
        }
    },

Given that the top-level JSON object is an array (and not a map), it would be nice if those entries were unique.

/cc @kwalrath

@jcollins-g
Copy link
Contributor

Some of these duplicates are "working as intended", because if Dart's Object class is not one of the documented entities, then inherited identifiers from it, like hashCode, will be "owned" by the closest class to Object in the inheritance chain.

However, dartdoc doesn't currently compute this right.

@jcollins-g jcollins-g added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P3 A lower priority bug or feature request customer-google3 Issues originating from or important to Angular labels May 15, 2017
@srawlins srawlins added type-performance Issues related to slow dartdoc generation. area-output-size Issues related to dartdoc's sometimes unreasonable output size. labels Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-output-size Issues related to dartdoc's sometimes unreasonable output size. customer-google3 Issues originating from or important to Angular P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-performance Issues related to slow dartdoc generation.
Projects
None yet
Development

No branches or pull requests

3 participants