-
Notifications
You must be signed in to change notification settings - Fork 124
Change the order of groups on dartdoc pages #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This list is approved. Go forth and make it awesome. |
cc @astashov if you're looking for one P2, this one is an easy one :) |
This has two parts influencing it: the script that constructs the "package" that dartdoc actually documents for flutter, and the dartdoc internal category sorting. Starting work on the latter, first. |
It's probably fine, but it's definitely suboptimal. We ideally want flutter_test (unit tests) above flutter_driver (integration tests, more complicated), and ideally want flutter_markdown (a flutter runtime package) before the test packages. Might be worth just giving us explicit control (maybe default to the order on the command line, say), that way you never have to worry about it again. :-) |
Sounds good. I'll still improve the automatic categorizing but give you control on the command line to override it. |
Also any improvement is an improvement, we're happy to take things bit by bit if that's more tractable than going all the way to space in one step. :-) |
It's alright, this isn't nearly as painful as #1334 turned out to be :-) |
Static properties weren't mentioned under classes in the order above, so moving them to before static methods. |
Can't fix this without touching the code for #1225, so fixing that too. |
Done, cleaned up and has tests, but stuck behind #1368. Some examples below from Flutter. Top level, with new --category-order flag set to: |
That is gorgeous. |
It looks like the order of groups on library, enum, and class pages hasn't changed. Should I file a separate bug to track those? |
The order right now is a bit weird (especially that typedefs come so early on the library page).
Here are the suggested new orders:
cc @sethladd
The text was updated successfully, but these errors were encountered: