Skip to content

[new ui.Gradient.linear] doesn't linkify #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue May 5, 2017 · 1 comment · Fixed by #1875
Closed

[new ui.Gradient.linear] doesn't linkify #1402

Hixie opened this issue May 5, 2017 · 1 comment · Fixed by #1875
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@Hixie
Copy link
Contributor

Hixie commented May 5, 2017

There's a couple of places where we refer to otherwise-ambiguous terms via the import prefix, e.g. [ui.Image.width], [new ui.Gradient.linear].

@Hixie Hixie added customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures labels May 5, 2017
@jcollins-g
Copy link
Contributor

This is going to be a challenging one to fix correctly. Because of canonicalization, we can no longer use commentRefs as a way to leverage the analyzer directly. So dartdoc's old fallback of attempting to compute fully qualified names for ModelElements and looking up things like ui.Image.width in a big table is now the primary means of doing non-local lookups. That doesn't work when import prefixes are involved. Out of necessity, #1390 made the old fallback more robust and and it now works for all the cases where it could, but it didn't alter the basic design.

For this fix, ModelElements will need to implement a "lookup" function, break down a name into its component parts, and traverse the ModelElement tree directly, so that special cases like import prefixes can be detected and handled. This will be more robust and likely better performing than the old method ever could be but is a non-trivial design change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants