Skip to content

Import prefix support for dartdoc #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 20, 2018
Merged

Import prefix support for dartdoc #1875

merged 11 commits into from
Dec 20, 2018

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Dec 19, 2018

Fixes #1402.

Implementation of prefix support for dartdoc. Also includes a restructuring of how constructors are handled. Class objects and constructors are now explicitly converted back and forth as a result of context information rather than indirectly through the code structure. Some more refactoring to straighten out edge cases related to this; a total of 70 or so broken links fixed for Flutter as a result.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 19, 2018
@coveralls
Copy link

coveralls commented Dec 19, 2018

Coverage Status

Coverage increased (+0.05%) to 89.652% when pulling 747a738 on prefix-support-dartdoc into 42bd3b4 on master.

@jcollins-g jcollins-g requested a review from pq December 19, 2018 23:09
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a total of 70 or so broken links fixed for Flutter as a result.

🎉

That's awesome.

Anyway, this is great. A few nits that you can, needless to say, ignore.

@@ -49,8 +49,11 @@ library fake;
import 'dart:async';
import 'dart:collection';
import 'package:meta/meta.dart' show Required;
import 'css.dart' as css;
import 'csspub.dart' as css;
import 'csspub.dart' as renamedLib2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Now this is really pathological.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's test code... that's it's job ;-)

@jcollins-g jcollins-g merged commit e864efe into master Dec 20, 2018
@jcollins-g jcollins-g deleted the prefix-support-dartdoc branch December 20, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new ui.Gradient.linear] doesn't linkify
4 participants