Repository navigation
Import prefix support for dartdoc - #1875
Merged
Merged
Conversation
pq
approved these changes
Dec 20, 2018
pq
left a comment
pq
left a comment
Member
There was a problem hiding this comment.
a total of 70 or so broken links fixed for Flutter as a result.
🎉
That's awesome.
Anyway, this is great. A few nits that you can, needless to say, ignore.
| import 'package:meta/meta.dart' show Required; | ||
| import 'css.dart' as css; | ||
| import 'csspub.dart' as css; | ||
| import 'csspub.dart' as renamedLib2; |
Member
There was a problem hiding this comment.
Oh. Now this is really pathological.
Contributor
Author
There was a problem hiding this comment.
It's test code... that's it's job ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1402.
Implementation of prefix support for dartdoc. Also includes a restructuring of how constructors are handled. Class objects and constructors are now explicitly converted back and forth as a result of context information rather than indirectly through the code structure. Some more refactoring to straighten out edge cases related to this; a total of 70 or so broken links fixed for Flutter as a result.