-
Notifications
You must be signed in to change notification settings - Fork 124
Import prefix support for dartdoc #1875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a total of 70 or so broken links fixed for Flutter as a result.
🎉
That's awesome.
Anyway, this is great. A few nits that you can, needless to say, ignore.
@@ -49,8 +49,11 @@ library fake; | |||
import 'dart:async'; | |||
import 'dart:collection'; | |||
import 'package:meta/meta.dart' show Required; | |||
import 'css.dart' as css; | |||
import 'csspub.dart' as css; | |||
import 'csspub.dart' as renamedLib2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. Now this is really pathological.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's test code... that's it's job ;-)
Fixes #1402.
Implementation of prefix support for dartdoc. Also includes a restructuring of how constructors are handled. Class objects and constructors are now explicitly converted back and forth as a result of context information rather than indirectly through the code structure. Some more refactoring to straighten out edge cases related to this; a total of 70 or so broken links fixed for Flutter as a result.