Skip to content

Refactor ModelElement.href implementations #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcollins-g opened this issue Dec 8, 2017 · 1 comment
Closed

Refactor ModelElement.href implementations #1567

jcollins-g opened this issue Dec 8, 2017 · 1 comment
Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@jcollins-g
Copy link
Contributor

Link calculation in Dartdoc currently makes #739 and #1343 somewhat challenging. There's no way to tell currently if dartdoc is calling href in a context where we know we should expect to have something to link (#1343). In addition, because of the way link calculation is handled, there's no easy way to insert alternate handling when we want to link externally (#739).

@jcollins-g jcollins-g added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P2 A bug or feature request we're likely to work on labels Dec 8, 2017
@jcollins-g
Copy link
Contributor Author

#1589 addressed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Development

No branches or pull requests

1 participant