Skip to content

dartdoc generates broken links to private classes in constant declarations #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcollins-g opened this issue Jan 10, 2018 · 0 comments · Fixed by #1589
Closed

dartdoc generates broken links to private classes in constant declarations #1588

jcollins-g opened this issue Jan 10, 2018 · 0 comments · Fixed by #1589
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented Jan 10, 2018 •
edited
Loading

Introduced in #1585. href generation should simply refuse to generate for a private link; we're to the point now where that's actually a better choice than most of the special casing.

screenshot from 2018-01-10 09 27 12
@jcollins-g jcollins-g added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Jan 10, 2018
@jcollins-g jcollins-g mentioned this issue Jan 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent private or non-canonical elements from ever generating links dart-lang/dartdoc
1 participant
@jcollins-g