Skip to content

Don't document protected members of @sealed classes #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nex3 opened this issue Nov 4, 2020 · 0 comments
Open

Don't document protected members of @sealed classes #2419

nex3 opened this issue Nov 4, 2020 · 0 comments
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@nex3
Copy link
Member

nex3 commented Nov 4, 2020

If a class is marked as @sealed, then external packages aren't allowed to extend it. This effectively means that any APIs that are only visible to subclasses, such as those marked @protected or constructors for abstract classes, aren't part of the package's public API and shouldn't be documented by dartdoc.

See also #2418.
nex3 added a commit to sass/dart-sass that referenced this issue Nov 5, 2020
@nex3
Use @internal to cordon off internal-only Value APIs
d007111 
This is a proof-of-concept for #236. Note that we need to add a bunch
of explicit @Nodoc annotations to work around dart-lang/dartdoc#2418
and dart-lang/dartdoc#2419.
@jcollins-g jcollins-g added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P2 A bug or feature request we're likely to work on labels Nov 5, 2020
nex3 added a commit to sass/dart-sass that referenced this issue Jun 24, 2021
@nex3
Use @internal to cordon off internal-only Value APIs
2395c5a 
Lays the groundwork for #236

Note that we need to add a bunch of explicit @Nodoc annotations to
work around dart-lang/dartdoc#2418 and dart-lang/dartdoc#2419.
@nex3 nex3 mentioned this issue Jun 24, 2021
Merged
nex3 added a commit to sass/dart-sass that referenced this issue Jun 25, 2021
@nex3
Use @internal to cordon off internal-only Value APIs (#1379)
a10d7c6 
Lays the groundwork for #236

Note that we need to add a bunch of explicit @Nodoc annotations to
work around dart-lang/dartdoc#2418 and dart-lang/dartdoc#2419.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @jcollins-g