Top right search bar not functioning correctly #3861
Assignees
Comments
|
Thanks for the report; on what pages do you see this buggy behavior? |
|
No worries. I think this happens in almost all of the pub.dev API reference page (e.g., for flutter_bloc documentation page). The freezed documentation page with one method which I mention before is a rare exception. |
srawlins
added a commit
to srawlins/dartdoc
that referenced
this issue
Sep 3, 2024
The library sidebars on container (e.g. Class), top-level variable, top-level function, and typedefs were totally busted, as a result of d629e1e. Fixes dart-lang#3859 and fixes dart-lang#3861. The fix is to allow a Library's `canonicalModelElement` to be it's canonical library, instead of `null`. This involves adding a few checks for "am I calculating something for a Library?" and moving some "is this library considered public" logic out of `Element.hasPrivateName` and into `ModelElement.isPublic`. That corrects the issue of an exported Class's (for example) enclosing element's URI, for the search results. Once all of that is fixed, we also correct the `aboveSidebarPath` implementation for a few elements, to point to the _canonical_ library's sidebar path. This fix highlights an issue with wildcard-variables, so one test is newly marked as failing.
srawlins
added
type-bug
srawlins
added a commit
to srawlins/dartdoc
that referenced
this issue
Sep 3, 2024
The library sidebars on container (e.g. Class), top-level variable, top-level function, and typedefs were totally busted, as a result of d629e1e. Fixes dart-lang#3859 and fixes dart-lang#3861. The fix is to allow a Library's `canonicalModelElement` to be it's canonical library, instead of `null`. This involves adding a few checks for "am I calculating something for a Library?" and moving some "is this library considered public" logic out of `Element.hasPrivateName` and into `ModelElement.isPublic`. That corrects the issue of an exported Class's (for example) enclosing element's URI, for the search results. Once all of that is fixed, we also correct the `aboveSidebarPath` implementation for a few elements, to point to the _canonical_ library's sidebar path. This fix highlights an issue with wildcard-variables, so one test is newly marked as failing.
srawlins
added a commit
to srawlins/dartdoc
that referenced
this issue
Sep 3, 2024
The library sidebars on container (e.g. Class), top-level variable, top-level function, and typedefs were totally busted, as a result of d629e1e. Fixes dart-lang#3859 and fixes dart-lang#3861. The fix is to allow a Library's `canonicalModelElement` to be it's canonical library, instead of `null`. This involves adding a few checks for "am I calculating something for a Library?" and moving some "is this library considered public" logic out of `Element.hasPrivateName` and into `ModelElement.isPublic`. That corrects the issue of an exported Class's (for example) enclosing element's URI, for the search results. Once all of that is fixed, we also correct the `aboveSidebarPath` implementation for a few elements, to point to the _canonical_ library's sidebar path. This fix highlights an issue with wildcard-variables, so one test is newly marked as failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the top right search bar, I got this buggy behaviours:
Loading screen...Interestingly, all these buggy behaviours don't happen in freezed documentation page, where it only consist of one method
*might be related with #3859
The text was updated successfully, but these errors were encountered: