Skip to content

Search on https://api.dart.dev/dev doesn't work #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkustermann opened this issue Sep 25, 2024 · 5 comments
Closed

Search on https://api.dart.dev/dev doesn't work #3889

mkustermann opened this issue Sep 25, 2024 · 5 comments

Comments

@mkustermann
Copy link
Member

The search field on https://api.dart.dev/dev doesn't work. It doesn't register the mouse click and one cannot enter text into it. Note this is specific to /dev and /stable seems to work.

In the console it shows an error

js_helper.dart:1198 Uncaught Error: TypeError: null: type 'minified:aM' is not a subtype of type 'String'
    at Object.a (js_helper.dart:1198:19)
    at Object.fz (rti.dart:1654:3)
    at cM.hD (search.dart:143:29)
    at ae.C (iterable.dart:425:29)
    at an.m (iterable.dart:354:5)
    at Object.hM (core_patch.dart:367:5)
    at Object.eW (core_patch.dart:348:39)
    at iterable.dart:224:7
    at dR.a (async_patch.dart:303:19)
    at dR.$2 (async_patch.dart:328:23)

/cc @devoncarew do you know who can take a look at this?

@devoncarew devoncarew transferred this issue from dart-archive/api.dart.dev Sep 25, 2024
@devoncarew
Copy link
Member

I assume the stacktrace is coming from dartdoc's embedded web app; cc @srawlins.

Sam, we may also consider less name mangling for the compiled web app? I'm not sure what the size tradeoff is.

@parlough
Copy link
Member

parlough commented Sep 25, 2024

@srawlins Was this the issue you fixed in #3877? Search seems to work on api.dart.dev/main.

@srawlins
Copy link
Member

I think so. I wish I could see when each dev/ docs was built and with what version of dartdoc, but I don't know how.

@parlough
Copy link
Member

I wish I could see when each dev/ docs was built and with what version of dartdoc

Perhaps there is a more direct way (or we should add one), but the footer does include the SDK version (currently 3.6.0-270.0.dev) which the DEPS file specifies dartdoc at 8100ccf which doesn't include that fix.

@srawlins
Copy link
Member

Today it seems to work. Can someone else confirm? (In case it it just some pages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants