-
Notifications
You must be signed in to change notification settings - Fork 125
Canonicalization scorer #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Canonicalization scorer #1455
Changes from 21 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c213186
First stab at disambiguation, but needs to be extracted
jcollins-g 1dab2d0
update from head
jcollins-g 787d4f8
scorer in pretty good shape now
jcollins-g bddeab3
Merge branch 'master' of github.com:dart-lang/dartdoc into canonicali…
jcollins-g 13717b5
beginnings of being able to set canonicalization manually
jcollins-g 004265c
Merge branch 'master' of github.com:dart-lang/dartdoc into canonicali…
jcollins-g 2ef88ba
intermediate state: moving to library-based canonicalFor declaration
jcollins-g 6258331
Merge branch 'master' of github.com:dart-lang/dartdoc into canonicali…
jcollins-g 5fa4ca1
intermediate state -- autoinclude deps broken
jcollins-g 4dedc21
intermediate: tests written and working
jcollins-g 7d307a9
test really works now.
jcollins-g 899eb15
regen test docs
jcollins-g 7fa1209
Add new test doc directories
jcollins-g 24e883f
dartfmt
jcollins-g c3de1bd
Comment typo.
jcollins-g d997568
Fix --auto-include-deps
jcollins-g 7ed0790
cleanup
jcollins-g 5bfff11
rebuild docs
jcollins-g abf875f
Helper moved with the fix.
jcollins-g e16af38
Hide the debug option for the scorer confidence
jcollins-g 8e880c4
Remove unnecessary casts
jcollins-g a69203a
Implement review comments and extract namePieces into Nameable
jcollins-g 9fe85f8
Merge branch 'master' of github.com:dart-lang/dartdoc into canonicali…
jcollins-g bc47ab2
Regenerate docs
jcollins-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a super long name for a flag. Is this even a flag that user's should toggle? Should we just decide on a good value for this?
If you need a flag for dev purposes, you can have a hidden option with the
hide: true
param.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
hide: true
.