-
Notifications
You must be signed in to change notification settings - Fork 125
Canonicalization scorer #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonicalization scorer #1455
Changes from 15 commits
c213186
1dab2d0
787d4f8
bddeab3
13717b5
004265c
2ef88ba
6258331
5fa4ca1
4dedc21
7d307a9
899eb15
7fa1209
24e883f
c3de1bd
d997568
7ed0790
5bfff11
abf875f
e16af38
8e880c4
a69203a
9fe85f8
bc47ab2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -152,21 +152,21 @@ main(List<String> arguments) async { | |
generator.onFileCreated.listen(_onProgress); | ||
} | ||
|
||
var addCrossdart = args['add-crossdart'] as bool; | ||
var includeSource = args['include-source'] as bool; | ||
|
||
DartSdk sdk = new FolderBasedDartSdk(PhysicalResourceProvider.INSTANCE, | ||
PhysicalResourceProvider.INSTANCE.getFolder(sdkDir.path)); | ||
|
||
setConfig( | ||
addCrossdart: addCrossdart, | ||
addCrossdart: args['add-crossdart'] as bool, | ||
examplePathPrefix: args['example-path-prefix'], | ||
showWarnings: args['show-warnings'], | ||
includeSource: includeSource, | ||
includeSource: args['include-source'] as bool, | ||
inputDir: inputDir, | ||
sdkVersion: sdk.sdkVersion, | ||
autoIncludeDependencies: args['auto-include-dependencies'], | ||
categoryOrder: args['category-order']); | ||
categoryOrder: args['category-order'], | ||
reexportMinConfidence: | ||
double.parse(args['ambiguous-reexport-scorer-min-confidence']), | ||
verboseWarnings: args['verbose-warnings'] as bool); | ||
|
||
DartDoc dartdoc = new DartDoc(inputDir, excludeLibraries, sdkDir, generators, | ||
outputDir, packageMeta, includeLibraries, | ||
|
@@ -266,6 +266,14 @@ ArgParser _createArgsParser() { | |
"Generates `index.json` with indentation and newlines. The file is larger, but it's also easier to diff.", | ||
negatable: false, | ||
defaultsTo: false); | ||
parser.addOption('ambiguous-reexport-scorer-min-confidence', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems like a super long name for a flag. Is this even a flag that user's should toggle? Should we just decide on a good value for this? If you need a flag for dev purposes, you can have a hidden option with the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added |
||
help: | ||
'Minimum scorer confidence to suppress warning on ambiguous reexport.', | ||
defaultsTo: "0.1"); | ||
parser.addFlag('verbose-warnings', | ||
help: 'Display extra debugging information and help with warnings.', | ||
negatable: true, | ||
defaultsTo: true); | ||
return parser; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if the analyzer needs this casting - do you get a warning without the
as bool
?