Skip to content

Make all markdown content render at 700px #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Make all markdown content render at 700px #1523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/resources/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ main {
padding: 20px 15px 0 30px;
}

.main-content p {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any consequences to removing this style?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this just applies the max-width property, which is now applied using the class="markdown desc" selector below.

max-width: 700px;
}

.sidebar,
.main-content {
margin: 20px 0;
Expand Down Expand Up @@ -416,6 +412,10 @@ footer a, footer a:hover {
color: #fff;
}

.markdown.desc {
max-width: 700px;
}

.markdown h1 {
font-size: 24px;
margin-bottom: 8px;
Expand Down
5 changes: 5 additions & 0 deletions testing/test_package/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ It also has some awesome code
void main() {
// in Dart!
}

/*
80-characters: to ensure default styles accommodate Dart line length convention.
01234567890123456789012345678901234567890123456789012345678901234567890123456789
*/
```

```yaml
Expand Down
5 changes: 5 additions & 0 deletions testing/test_package_docs/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ <h1>Best Package</h1>
<pre class="language-dart"><code class="language-dart">void main() {
// in Dart!
}

/*
80-characters: to ensure default styles accommodate Dart line length convention.
01234567890123456789012345678901234567890123456789012345678901234567890123456789
*/
</code></pre>
<pre class="language-yaml"><code class="language-yaml">and_yaml:
- value
Expand Down
8 changes: 4 additions & 4 deletions testing/test_package_docs/static-assets/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ main {
padding: 20px 15px 0 30px;
}

.main-content p {
max-width: 700px;
}

.sidebar,
.main-content {
margin: 20px 0;
Expand Down Expand Up @@ -416,6 +412,10 @@ footer a, footer a:hover {
color: #fff;
}

.markdown.desc {
max-width: 700px;
}

.markdown h1 {
font-size: 24px;
margin-bottom: 8px;
Expand Down