Skip to content

canonicalization overhaul part 3: Types, Templates, and Public/Private #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 30, 2017
Merged

canonicalization overhaul part 3: Types, Templates, and Public/Private #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b3ef88d
Flatten changes one last time
jcollins-g Nov 28, 2017
971153c
Merge branch 'master' of github.com:dart-lang/dartdoc into fix-type-p…
jcollins-g Nov 28, 2017
e1e06cd
Merge branch 'master' of github.com:dart-lang/dartdoc into fix-type-p…
jcollins-g Nov 30, 2017
7a134cc
Fix tests post analyzer update
jcollins-g Nov 30, 2017
93a6d87
Review comments
jcollins-g Nov 30, 2017
eedcc55
Disable travis temporarily
jcollins-g Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ env:
- DARTDOC_BOT=main
# TODO(devoncarew): add angulardart support
#- DARTDOC_BOT=angular
- DARTDOC_BOT=flutter
# TODO(jcollins-g): reenable flutter once it gets flags changed post #1524
#- DARTDOC_BOT=flutter
- DARTDOC_BOT=sdk-docs
script: ./tool/travis.sh
branches:
Expand Down
8 changes: 5 additions & 3 deletions bin/dartdoc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,11 +261,11 @@ main(List<String> arguments) async {
reexportMinConfidence:
double.parse(args['ambiguous-reexport-scorer-min-confidence']),
verboseWarnings: args['verbose-warnings'],
excludePackages: args['exclude-packages'],
dropTextFrom: dropTextFrom);

DartDoc dartdoc = new DartDoc(inputDir, excludeLibraries, sdkDir, generators,
outputDir, packageMeta, includeLibraries,
includeExternals: includeExternals);
outputDir, packageMeta, includeLibraries, includeExternals);

dartdoc.onCheckProgress.listen(logProgress);
await Chain.capture(() async {
Expand All @@ -275,7 +275,7 @@ main(List<String> arguments) async {
},
zoneSpecification: new ZoneSpecification(
print: (Zone self, ZoneDelegate parent, Zone zone, String line) =>
logPrint(line) ));
logPrint(line)));
}, onError: (e, Chain chain) {
if (e is DartDocFailure) {
stderr.writeln('\nGeneration failed: ${e}.');
Expand Down Expand Up @@ -325,6 +325,8 @@ ArgParser _createArgsParser() {
'(optional text next to the package name and version).');
parser.addOption('exclude',
allowMultiple: true, splitCommas: true, help: 'Library names to ignore.');
parser.addOption('exclude-packages',
allowMultiple: true, splitCommas: true, help: 'Package names to ignore.');
parser.addOption('include',
allowMultiple: true,
splitCommas: true,
Expand Down
Loading