Centralize all file writing in HtmlGeneratorInstance #1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything gets logged. Everything gets checked for dupes. Much easier to add 'no-op' support to validate code structure without writing the output
kevmoo
force-pushed
the
centralize_writing
branch
from
1e78745 to
ad58e3b
Compare
jcollins-g
reviewed
Nov 6, 2017
There was a problem hiding this comment.
I believe this obsoletes the hack at: https://github.com/dart-lang/dartdoc/blob/master/lib/dartdoc.dart#L274
to handle static assets separately in the link checker. Can you clean that up as part of this PR?
Just that one |
kevmoo
force-pushed
the
centralize_writing
branch
from
ad58e3b to
4dd0e03
Compare
|
Unfortunately, looking at the output from flutter on travis, the link checker doesn't like that. |
kevmoo
force-pushed
the
centralize_writing
branch
from
4dd0e03 to
ad58e3b
Compare
Yup. Reverted. If means a fail, we should update the test to fail in that case... |
|
@jcollins-g – LGTY? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything gets logged.
Everything gets checked for dupes.
Much easier to add 'no-op' support to validate code structure without writing the output
Related to #1537