Skip to content

Warnings enhancements from #1524 #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2017
Merged

Warnings enhancements from #1524 #1539

merged 4 commits into from
Nov 20, 2017

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Nov 15, 2017 •
edited
Loading

This is the first breakout piece from canonicalization overhaul part 3 (#1524). Mostly minor changes here.

  • Clean up output when --show-progress isn't given
  • Move location splitting into the Warnable class
  • Allow for warnings that generate more warnings when calculating warning text (required for the rest of the overhaul)
  • Avoid a crash if no warnings or errors are generated (use fold instead of reduce)

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Nov 15, 2017
kevmoo
kevmoo reviewed Nov 15, 2017
View reviewed changes
lib/src/warnings.dart Outdated
abstract class Warnable implements Locatable {
void warn(PackageWarning warning,
{String message, Iterable<Locatable> referredFrom});
Warnable get enclosingElement;

Set<String> get locationPieces {
return new Set()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't there a from ctor on Set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jcollins-g jcollins-g merged commit 56a0148 into master Nov 20, 2017
@jcollins-g jcollins-g deleted the warnings-breakout branch November 20, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo left review comments

@devoncarew devoncarew devoncarew approved these changes

@keertip keertip Awaiting requested review from keertip

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @kevmoo @devoncarew @googlebot