Update mustache4dart and clean up templates #1540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Nov 27, 2017
lib/src/model.dart
Outdated
|
|
||
| @override | ||
| Set<String> get features { | ||
| Set<String> all_features = super.features; |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1525, #1286. This is the second breakout from #1524.
The public/private refactoring in #1524 required a large number of renames to methods used by the templates. It was extremely difficult to change those without the verification provided by a new version of mustache4dart that will raise an exception on a missing method, so updated that. That in turn revealed more bugs and problems with the use of templates, as well as some inconsistencies in output. These are fixed here.
To make reviewing the output changes easier I have the old and new versions of the test package docs serving. I suggest comparing the members of "ClassWithUnusualProperties" as properties have the most significant changes here -- most others are whitespace or HTML metadata.
old:
http://jcollins1.pdx.corp.google.com:8000/fake/ClassWithUnusualProperties-class.html
new:
http://jcollins1.pdx.corp.google.com:8001/fake/ClassWithUnusualProperties-class.html