Fix truncation in middle of links for constants #1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Nov 27, 2017
| } | ||
|
|
||
| String linkifyWithModelType(String text) { | ||
| RegExp r = new RegExp("\\b${modelType.name}\\b"); |
There was a problem hiding this comment.
Is this called frequently? If so, we may want to cache the regexp in an instance field.
There was a problem hiding this comment.
This method is not called very often per GetterSetterCombo (maybe twice?). Probably not worth it at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535. Third breakout from #1524 -- necessary because #1535 becomes much worse with the overhaul as more classes are made linkable. Without this change #1535 would become a P1 post-overhaul as Flutter docs would begin generating broken links and warning about them.
Rearranges how constantValue is calculated, factoring it out into GetterSetterCombo and substituting any links in after truncating and escaping, rather than before.