Skip to content

Page title tweak #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2018
Merged

Page title tweak #1581

merged 3 commits into from
Jan 3, 2018

Conversation

devoncarew
Copy link
Member

Done as 2 commits to make the review slightly easier.

screen shot 2018-01-02 at 5 08 51 pm

@jcollins-g

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 3, 2018
@devoncarew
Copy link
Member Author

Also, re-ordered other labels on the page to be $name $kind; thoughts welcome :)

Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the changes, and it would look weird I think if we didn't change it in all these places.

@devoncarew devoncarew merged commit 75c5573 into master Jan 3, 2018
jcollins-g added a commit that referenced this pull request Jan 4, 2018
jcollins-g added a commit that referenced this pull request Jan 9, 2018
…rmation analyzer already has. (#1585)

* First version of adding const

* Serve test package docs through grinder

* Almost done, finish test for STUFF

* pubspec update

* Fix label for test package server

* Fix up const-declaration

* dartfmt

* Fix inconsistencies in #1581

* WIP

* rebuild test package docs
@kevmoo kevmoo deleted the page_title_tweak branch January 11, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New styles on Flutter dartdocs are too subdued
3 participants