Skip to content

Do not throw on malformed UTF-8 encodings #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2019
Merged

Do not throw on malformed UTF-8 encodings #1890

merged 2 commits into from
Jan 8, 2019

Conversation

jcollins-g
Copy link
Contributor

Fixes #1889.

For README, CHANGELOG, and other non-critical files, do not require valid UTF-8 encoding.

This may result in corrupted HTML output, but will no longer throw.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 7, 2019
@jcollins-g jcollins-g mentioned this pull request Jan 7, 2019
Closed
@coveralls
Copy link

coveralls commented Jan 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 92.666% when pulling 2c0efc9 on handle-corrupt-utf8 into 7930d89 on master.

@jcollins-g jcollins-g requested a review from pq January 7, 2019 22:45
pq
pq approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcollins-g jcollins-g merged commit 11abbbc into master Jan 8, 2019
@jcollins-g jcollins-g deleted the handle-corrupt-utf8 branch January 11, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @pq @googlebot