Skip to content

Convert originalMember to an optional parameter of ModelElement #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2021
Merged

Convert originalMember to an optional parameter of ModelElement #2507

merged 1 commit into from
Feb 8, 2021

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 7, 2021

We're now in a world with dart-lang/sdk#15101 and dart-lang/sdk#31543 fixed, so this change should be fine.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Feb 7, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.611% when pulling b72c128 on parlough:fix/model-element-optional-param-todo into d58b6d5 on dart-lang:master.

jcollins-g
jcollins-g approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@jcollins-g jcollins-g merged commit 90dc43b into dart-lang:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parlough @coveralls @jcollins-g