Skip to content

Cleanup some doc methods #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 8, 2021
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 7, 2021

Clean up some documentation and hasDocumentation methods to locally cache values and deprecate hasDocumentationFile in favor of documentationFile signifying the lack of one with a nullable result. Also make some minor changes to improve type inference once we switch to null safety.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Feb 7, 2021
@coveralls
Copy link

coveralls commented Feb 7, 2021

Coverage Status

Coverage decreased (-0.006%) to 91.579% when pulling a840b95 on parlough:misc/doc-methods into 703e08d on dart-lang:master.

Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny typo crept in.

@parlough
Copy link
Member Author

parlough commented Feb 8, 2021

Actions is pretty sluggish today... 🐌

@jcollins-g jcollins-g merged commit 60bb05a into dart-lang:master Feb 8, 2021
@parlough parlough deleted the misc/doc-methods branch February 8, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants