Skip to content

Mustachio: Store SourceSpans on MustachioNodes, for errors #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2021
Merged

Mustachio: Store SourceSpans on MustachioNodes, for errors #2515

merged 3 commits into from
Feb 10, 2021

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Feb 8, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Feb 8, 2021
@coveralls
Copy link

coveralls commented Feb 9, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 91.629% when pulling 35c6277 on srawlins:mustachio-k into 8934e55 on dart-lang:master.

@srawlins srawlins requested a review from jcollins-g February 9, 2021 00:08
@jcollins-g
Copy link
Contributor

Failure looks legit; maybe the test is not flexible for different error messages on windows?

@srawlins
Copy link
Member Author

srawlins commented Feb 9, 2021

Thanks for catching that; fixed by using Uri objects instead of String paths.

@srawlins srawlins merged commit ab44754 into dart-lang:master Feb 10, 2021
@srawlins srawlins deleted the mustachio-k branch February 10, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srawlins @coveralls @jcollins-g @parlough