Mustachio: fix getter override order, and bounds bug #2523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Single failure is... unrelated? Can't tell what went wrong. |
|
Yes that is... very strange looking. I would have expected the vm-service flag to cause problems for all the tests, not just one of them. I have pressed the retry everything button to see if it can be reproduced. |
jcollins-g
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Maybe a different problem, but should we consider expanding timeouts here: https://github.com/dart-lang/dartdoc/pull/2523/checks?check_run_id=1912657126? Might help make tests less flaky on CI.
parlough
approved these changes
Feb 16, 2021
|
Yay tests pass. |
srawlins
added a commit
to srawlins/dartdoc
that referenced
this pull request
Mar 9, 2021
Mustachio: fix getter override order, and bounds bug Fix indentation in category.html (dart-lang#2521) WIP: flip to mustachio
srawlins
added a commit
to srawlins/dartdoc
that referenced
this pull request
Mar 11, 2021
Mustachio: fix getter override order, and bounds bug Fix indentation in category.html (dart-lang#2521) WIP: flip to mustachio
srawlins
added a commit
to srawlins/dartdoc
that referenced
this pull request
Mar 12, 2021
Mustachio: fix getter override order, and bounds bug Fix indentation in category.html (dart-lang#2521) WIP: flip to mustachio
srawlins
added a commit
to srawlins/dartdoc
that referenced
this pull request
Mar 12, 2021
Mustachio: fix getter override order, and bounds bug Fix indentation in category.html (dart-lang#2521) WIP: flip to mustachio
srawlins
added a commit
to srawlins/dartdoc
that referenced
this pull request
Mar 17, 2021
Mustachio: fix getter override order, and bounds bug Fix indentation in category.html (dart-lang#2521) WIP: flip to mustachio
srawlins
added a commit
to srawlins/dartdoc
that referenced
this pull request
Mar 18, 2021
Mustachio: fix getter override order, and bounds bug Fix indentation in category.html (dart-lang#2521) WIP: flip to mustachio
srawlins
added a commit
to srawlins/dartdoc
that referenced
this pull request
Mar 28, 2021
Mustachio: fix getter override order, and bounds bug Fix indentation in category.html (dart-lang#2521) WIP: flip to mustachio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There aren't any new test cases, but the existing tests would fail with the changes to foo.dart, without the other changes to the codegen.
The main fix here is to apply local getters after inherited getters, in the property map, so that they override any inherited getters.
But in creating the test situation in foo.dart, I saw we had a bug with type parameter bounds as well. This is important for real cases like
ClassTemplateData<T extends Class> extends TemplateData<T>.