Skip to content

Fix duplicate field on static const extension method #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jcollins-g
Copy link
Contributor

This fixes a bug where dartdoc will throw trying to write a duplicate file for a static const declaration inside an extension. Also, corrects some analysis issues and adds enforcement of no analysis errors (yet, allowing warnings) within the two main test packages.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Mar 18, 2021
@coveralls
Copy link

coveralls commented Mar 18, 2021

Coverage Status

Coverage increased (+0.03%) to 91.289% when pulling f72eab7 on jcollins-g:enforce-analysis-test-packages into 0a83b0f on dart-lang:master.

@jcollins-g jcollins-g requested a review from srawlins March 18, 2021 22:47
@jcollins-g jcollins-g merged commit 8b911bc into dart-lang:master Mar 19, 2021
@jcollins-g jcollins-g deleted the enforce-analysis-test-packages branch March 19, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants