-
Notifications
You must be signed in to change notification settings - Fork 124
Generate renderers in a stable sort order #2611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jcollins-g do you know if something has changed in the SDK to make those few tests fail? Something about releasing a 2.14 dev maybe? |
@srawlins not sure, will take a look though. At first glance, not looking too deeply, it seems like it fails on both stable and dev SDKs so not sure the SDK would be to blame? |
Lol that grinder exception has a bug:
came from const expectedLibCounts = [0, 1];
const expectedTotalCount = [19, 20];
if (!expectedLibCounts.contains(foundLibs)) {
fail(
'expected $expectedTotalCount dart: index.html entries, found $foundLibs');
} |
well it is never supposed to actually fail here :-D |
Also
Annotation
from@Renderer
s. Not necessary.This is a pretty huge opaque change to the renderers, but should make future changes much smaller, keeping the renderers sorted.