Generic metadata and type parameters fixup #2649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
May 19, 2021
jcollins-g
added a commit
to jcollins-g/dartdoc
that referenced
this pull request
May 20, 2021
jcollins-g
added a commit
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2517. (Depending on whether or not we consider dart-lang/sdk#46064 blocking).
Rearranges how we handle typedefs to always render docs for typedefs as though they were declared in the new style, eliminating a lot of old special-casing.
Some sample renders:
(This one is missing metadata on the right hand side due to the analyzer issue)
Legacy renders, all except NewGenericTypedef are using the old style of function typedefs: