Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3171 and #3175. It's a big PR as I refactored a lot of code so that I could understand it better.
Mini results
Full page
initializeSearch
was ~450 lines, so I split out the local functions where I was editing code.iterateCategoriesMap
and just inline its code.handle
tohandleSearch
.handle
'sbool
optional parameter to be named, to fit with Effective Dart.There is a fair amount that could still be improved here (see other bugs), but (a) we don't have any automated testing for the generated JS app 😦 and (b) I should stop here and land something.