Refactor search ranking #3424
Merged
Refactor search ranking #3424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
May 30, 2023
lib/src/search.dart
Outdated
| final String name; | ||
| final String qualifiedName; | ||
|
|
||
| // TODO(srawlins): Store the integer of in the package order instead of this |
There was a problem hiding this comment.
nit: the index of the package in package order or similar
lib/src/search.dart
Outdated
| // "name":"dartdoc", | ||
| // "qualifiedName":"dartdoc", | ||
| // "href":"dartdoc/dartdoc-library.html", | ||
| // "type":"library", |
There was a problem hiding this comment.
this might be a field that could be crushed into an integer too, if needed.
There was a problem hiding this comment.
Yeah, it would be nice. We actually display the "type" in the search result so we would have to store the "type" as an int (rather convert to a scope), but yes still savings.
lib/src/search.dart
Outdated
| // ```dart | ||
| // { | ||
| // "name":"dartdoc", | ||
| // "qualifiedName":"dartdoc", |
There was a problem hiding this comment.
nit: example as "libName.variableName" might be better?
| ); | ||
| } | ||
|
|
||
| int get _scope => |
There was a problem hiding this comment.
A comment explaining this would be nice.
There was a problem hiding this comment.
Good call, done! And added a TODO, as its not well-tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few items of note:
lib/and add rudimentary tests. (work towards search UI redux #3419)--package-orderflag. (work towards Search results rankings are not always what I'd expect #3176)