Dedupliate library elements #3838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change that deduplicates library elements is splitting `Library.exportedAndLocalElements` into `Library._localElements` and `Library._exportedElements`, and then `Library._elementsOfType` into `Library._localElementsOfType` and `Library._exportedElementsOfType`. These two lists are separated so that the ModelElements can be instantiated or fetched from the package graph with the "correct" enclosing library. `_localElementsOfType` fetches elements via `getModelFor(e, this)`, and `exportedElementsOfType` fetches elements via `getModelFor(e, packageGraph.getModelForElement(library))`. Other changes to support this: * Use an element's `canonicalLibrary` instead of `library` in many places, like in each override of `filePath`, and in GeneratorFrontEnd. * There is no longer a distinction between an element's library and its _defining_ library. `ModelElement.definingLibrary` is removed. * Introduce a `canonicalizedQualifiedName` to use when creating `index.json`, which is the same as `fullyQualifiedName` but using the element's canonical library. * The global map of all elements was keyed on a 3-element key, which can now be a 2-element key (ConstructedModelElementsKey). * Remove an assert in Inheritable that no longer makes sense with this new model.
srawlins
force-pushed
the
no-dupe-libraries-2
branch
from
dc05cd4 to
2515ab8
Compare
|
Ready for review, @dart-lang/analyzer-team |
bwilkerson
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3748. Work towards #2021.
This change removes duplication of elements that are declared in one library and exported in another.
The main change that deduplicates library elements is splitting
Library.exportedAndLocalElementsintoLibrary._localElementsandLibrary._exportedElements, and thenLibrary._elementsOfTypeintoLibrary._localElementsOfTypeandLibrary._exportedElementsOfType. These two lists are separated so that the ModelElements can be instantiated or fetched from the package graph with the "correct" enclosing library._localElementsOfTypefetches elements viagetModelFor(e, this), andexportedElementsOfTypefetches elements viagetModelFor(e, packageGraph.getModelForElement(library)).Other changes to support this:
canonicalLibraryinstead oflibraryin many places, like in each override offilePath, and in GeneratorFrontEnd.ModelElement.definingLibraryis removed.canonicalizedQualifiedNameto use when creatingindex.json, which is the same asfullyQualifiedNamebut using the element's canonical library.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.