Do not make a copy of PUB_CACHE, just create an empty one instead. #4032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Apr 17, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 28, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/1788710..1a08646): 1a08646a 2025-04-28 Sam Rawlins Stop using InterfaceElementImpl2 (dart-lang/dartdoc#4041) 38b7d2e0 2025-04-28 Sam Rawlins Stop using ConstructorElementImpl (dart-lang/dartdoc#4040) ad65ae89 2025-04-25 Sarah Zakarias Make redirect pages for categories (dart-lang/dartdoc#4037) 9ab9ba05 2025-04-23 Parker Lougheed Migrate remaining styles to use sass nesting (dart-lang/dartdoc#4024) aaea6377 2025-04-22 Jonas Finnemann Jensen Use _category name_ in the URL, instead of the _category displayName_. (dart-lang/dartdoc#4031) 0388c64e 2025-04-22 Jonas Finnemann Jensen Do not make a copy of PUB_CACHE, just create an empty one instead. (dart-lang/dartdoc#4032) tools (https://github.com/dart-lang/tools/compare/11a7719..11f4cf7): 11f4cf7e 2025-04-24 Callum Moffat [html] Various performance optimizations (dart-lang/tools#2019) 98d4e4d9 2025-04-22 Simone Stasi [html] fix TypeError in nth-child query selector (dart-lang/tools#2015) Change-Id: Ic5d0a5f7f9393fa1a585b80ec1e014647224f151 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425200 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying my 11GB
PUB_CACHEcrashedcreateThrowawayPubCache, something aboutLink. But fundamentally, it's probably almost as fast to just download the packages again.And if we really want to avoid downloading the
PUB_CACHEwe could avoidglobal activate, or create aPUB_CACHEwe can clone inside.dart_tool/.But creating a copy of the default
PUB_CACHEis not likely to be faster, and probably harder to do, since you can have entire git checkouts, and legacy packages that were extracted with systemtarwhich might have symlinks inside them 🙈(You could also argue I should clean up my 11GB
PUB_CACHE, 🤣)