Refactor 404 error page to use div instead of p for search form#4038
Closed
AndrewDongminYoo wants to merge 2 commits into
Closed
Refactor 404 error page to use div instead of p for search form#4038AndrewDongminYoo wants to merge 2 commits into
AndrewDongminYoo wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
30a8960 to
bf2981b
Compare
Contributor
|
Thanks for you contribution. Can you rebase and maybe take a look at the failing tests? |
The search form on the 404 error page was previously wrapped in a `<p>` tag, which is semantically incorrect as `<p>` tags cannot contain block-level elements like `<form>`. This commit refactors the page to use a `<div>` tag instead, which is a more appropriate container for the search form. This change improves the semantic structure of the page and avoids potential rendering issues.
bf2981b to
e3f847d
Compare
szakarias
approved these changes
Jun 2, 2025
Author
|
Thanks to approve it!! |
Contributor
|
Was this landed? |
Contributor
|
No, I made a copy of it here #4064 . @AndrewDongminYoo is it okay with you if we land the copy? Otherwise maybe you could restore the branch and this PR? |
Author
|
@szakarias Yes, totally fine! Thanks for taking care of it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 404 error page’s search form was wrapped in a <p> tag, but <p> cannot contain block-level elements like <form>. This change refactors the markup to use a <div> instead, which:
Files changed:
doc/api/__404error.html(replace <p>…</p> around the form with <div>…</div>)No behavior changes beyond markup.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.