#4134. Add placement tests for private top-level declarations #4188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jan 30, 2026
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Random thought: The phrase 'can be placed' occurs many times. However, the remaining parts of the associated source code shows that DartDoc comments can be placed in other locations as well, in the sense that nothing stops working just because we add those DartDoc comments. Perhaps 'can be recognized' would be more to the point?
Collaborator
Author
|
Thanks. Makes sense. Updated. |
Collaborator
Author
|
Removed tests for private getters and setters. Added a TODO instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.