Convert some "mixed-in field" tests into unit tests #4197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These "mixed-in field" tests are a little complex, involving four types and a diamond-shaped inheritance graph. But they are meaningful; sort of the smallest diamond-shape of inheritance. I struggled to make sense of the end-to-end tests (as a change I was making was breaking them) and just had to convert them to unit tests to make them make sense 😅 .