Support the HTTP package on nodejs platform

[bramp]

I'm not sure if this is a bug, or a feature request. We use nodejs to test our projects when compiled with dart2js, but we noticed that the HTTP APIs don't seem to work on nodejs, but do within Chrome.

Take for example

import 'package:test/test.dart';
import 'package:http/http.dart' as http;

void main() {
  test('Simple http get', () async {
    final client = http.Client();

    final response = await client.get(Uri.http('localhost:8080'));

    expect(response.statusCode, 200);
  });
}

Dart VM

$ dart test test/node_test.dart
00:00 +1: All tests passed!

Chrome
Make sure your webserver returns a appropriate CORS header, e.g "Access-Control-Allow-Origin: *"

$ dart test test/node_test.dart -p chrome
00:03 +1: All tests passed!

Node (which fails)

$ dart test test/node_test.dart -p node

00:03 +0 -1: Simple http get [E]
  Error: self.XMLHttpRequest is not a constructor
  org-dartlang-sdk:///lib/_internal/js_shared/lib/js_util_patch.dart 307:10  <fn>
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 307:19   _wrapJsFunctionForAsync.closure.$protected
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 332:23   _wrapJsFunctionForAsync.<fn>
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 283:19   _awaitOnObject.<fn>
  org-dartlang-sdk:///lib/async/zone.dart 1407:46                            StaticClosure._rootRunUnary
  org-dartlang-sdk:///lib/async/zone.dart 1307:34                            _CustomZone.runUnary
  org-dartlang-sdk:///lib/async/future_impl.dart 127:29                      _Future._propagateToListeners.handleValueCallback
  org-dartlang-sdk:///lib/async/future_impl.dart 875:13                      Object._Future._propagateToListeners
  org-dartlang-sdk:///lib/async/future_impl.dart 647:5                       _Future._completeWithValue
  org-dartlang-sdk:///lib/async/future_impl.dart 721:7                       _Future._asyncCompleteWithValue.<fn>

[Zekfad]

If you're using node v18+ you can try fetch instead of XHR
Ref: https://nodejs.org/dist/latest/docs/api/globals.html#fetch

[bramp]

Thanks Zekfad, if that's addressed to me, I don't control how the 'package:http/http.dart' package works internally, but it should be agnostic to the platform dart is running on. As a workaround, that may be suitable suggestion, but for now, I've just switched all our testing to the Chrome browser.

[Zekfad]

You can use userland client implementation, e.g. fetch_client uses fetch api to implement http client. That in theory should work fine, if node is 18+, with global fetch function.

[alextekartik]

Interstingly, in my latest testing, the http package seems to work fine on node.

dart test -p node

is successful and I'm able to use some google api with a service account in a dart app compiled as node js. I don't know if it is intended or tested but that's great (I was using the fetch_client package before).

Well after looking more at it trying to run test in html - adding @TestOn('browser||node') - do fail...

fetch_client however works better and is almost able to pass conformance test