Skip to content

Don't use new function syntax #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevmoo opened this issue Oct 3, 2017 · 2 comments · Fixed by dart-archive/http2#16
Closed

Don't use new function syntax #1349

kevmoo opened this issue Oct 3, 2017 · 2 comments · Fixed by dart-archive/http2#16
Assignees
@jakobr-google
Labels
package:http2

Comments

@kevmoo
Copy link
Member

kevmoo commented Oct 3, 2017

Commit e787697 uses the new function syntax which is broken on 1.24.2

This is breaking folks – ship 0.1.4+1 using typedefs.

Would be good to get tests running on Travis to validate things...
@kevmoo kevmoo mentioned this issue Oct 3, 2017
Closed
@kevmoo
Copy link
Member Author

kevmoo commented Oct 3, 2017

See failure here - https://travis-ci.org/dart-lang/http2/jobs/282910913

jakobr-google referenced this issue in jakobr-google/http2 Oct 4, 2017
@jakobr-google
Remove use of new Function syntax for onActiveStateChanged.
3d14047 
The new syntax isn't fully supported in 1.24, so switching back to good
old typedef.

Fixes #14.
@jakobr-google jakobr-google mentioned this issue Oct 4, 2017
Merged
jakobr-google referenced this issue in jakobr-google/http2 Oct 5, 2017
@jakobr-google
Remove use of new Function syntax for onActiveStateChanged.
8149772 
The new syntax isn't fully supported in 1.24, so switching back to good
old typedef.

Fixes #14.
mkustermann referenced this issue in dart-archive/http2 Oct 5, 2017
@jakobr-google @mkustermann
Remove use of new Function syntax for onActiveStateChanged. (#16)
dd58f61 
The new syntax isn't fully supported in 1.24, so switching back to good
old typedef.

Fixes #14.
@kevmoo
Copy link
Member Author

kevmoo commented Oct 5, 2017

Thank you, @jakobr-google ! 🙌

mosuem referenced this issue Oct 17, 2024
@jakobr-google @mkustermann
Remove use of new Function syntax for onActiveStateChanged. (dart-arc…
cb6b083 
…hive/http2#16)

The new syntax isn't fully supported in 1.24, so switching back to good
old typedef.

Fixes dart-lang/http2#14.
@mosuem mosuem transferred this issue from dart-archive/http2 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobr-google jakobr-google

Labels
package:http2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of new Function syntax for onActiveStateChanged. jakobr-google/http2
3 participants
@kevmoo @jakobr-google @mosuem