This repository was archived by the owner on Jan 13, 2025. It is now read-only.
Remove use of new Function syntax for onActiveStateChanged. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase over latest – and you'll get the travis check, too! |
kevmoo
reviewed
Oct 4, 2017
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: http2 | |||
| version: 0.1.4 | |||
| version: 0.1.5 | |||
There was a problem hiding this comment.
This can/should be 0.1.4+1
No new features – just a fix
There was a problem hiding this comment.
I've always thought the +N's were silly. It's build metadata, which should be ignored when determining precedence. Yes, I know we pinned ourselves to 2.0.0-rc1 of semver to get around this, since the final 2.0.0 release specifically says to ignore build metadata, but why?
Semver also says that the patch version should increase for backwards compatible bugfixes, which is what this is.
(And you could rightfully argue that the 0.1.4 release should have been 0.2.0, since I added new, backwards compatible, public API...)
The new syntax isn't fully supported in 1.24, so switching back to good old typedef. Fixes #14.
mosuem
pushed a commit
to dart-lang/http
that referenced
this pull request
Oct 17, 2024
…hive/http2#16) The new syntax isn't fully supported in 1.24, so switching back to good old typedef. Fixes dart-lang/http2#14.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new syntax isn't fully supported in 1.24, so switching back to good
old typedef.
Fixes dart-lang/http#1349.