Skip to content

BrowserClient doesn't have a way to set withCredentials=true so Cookies aren't being sent accros domains. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Jun 5, 2015 · 3 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

Originally opened as dart-lang/sdk#23088

This issue was originally filed by [email protected]


I don't see any way currently to set withCredentials=true on BrowserClient so that I can send cookies across domains (this is especially important in dev as I'm developing on one server and the dart client is on another server which I believe is a common use-case scenario).

What steps will clearly show the issue / need for enhancement?
1: I can easily allow cross-domain communication by setting CORS headers on the server side, as soon as I want to send back a cookie from the server to maintain state on the client side, I can't do it. I've looked at HTML5 localstorage, but that's not secure, I need to be able to set Cookies with HttpOnly and Secure flags so that JavaScript can't access it.
2: I see angular.dart made provision for the withCredentials flag to allow sending cookies across domains.

What is the current output?
Seeing cookie headers coming back from the server, but not on the request.

What would you like to see instead?
Seeing cookie headers on both the request and response.

What version of the product are you using? On what operating system?
Dart 1.9

Please provide any additional information below.
See my StackOverflow post: http://stackoverflow.com/questions/29427203/dart-browserclient-post-not-including-my-cookies

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5449880?v=3" align="left" width="48" height="48"hspace="10"> Comment by iposva-google


Added Area-Pkg, Pkg-Http, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/405837?v=3" align="left" width="48" height="48"hspace="10"> Comment by zoechi


The most recent version published Apr 6th does have this.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


For future reference, file http issues on http://github.com/dart-lang/http/issues.


Added Fixed label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant