Upgrade to package:objective_c` 4.0 - #1406
Merged
Merged
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
| File | Coverage |
|---|---|
| pkgs/cupertino_http/example/integration_test/utils_test.dart | 💔 Not covered |
| pkgs/cupertino_http/lib/src/cupertino_api.dart | 💔 Not covered |
| pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
License Headers ⚠️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/cronet_http/lib/src/jni/jni_bindings.dart |
| pkgs/http/example/main.dart |
| pkgs/http2/test/src/flowcontrol/mocks.mocks.dart |
| pkgs/http_client_conformance_tests/example/client_test.dart |
| pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart |
| pkgs/http_client_conformance_tests/lib/src/multipart_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/multipart_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/redirect_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/redirect_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/request_body_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/request_body_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/request_cookies_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/request_cookies_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/request_headers_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/request_headers_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/request_methods_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/request_methods_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/response_body_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/response_body_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/response_cookies_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/response_cookies_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/response_headers_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/response_headers_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/response_status_line_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/response_status_line_server_web.dart |
| pkgs/http_client_conformance_tests/lib/src/server_errors_server_vm.dart |
| pkgs/http_client_conformance_tests/lib/src/server_errors_server_web.dart |
| pkgs/http_parser/test/example_test.dart |
| pkgs/http_profile/lib/http_profile.dart |
| pkgs/ok_http/lib/src/jni/bindings.dart |
| pkgs/web_socket/example/web_socket_example.dart |
| pkgs/web_socket/lib/testing.dart |
| pkgs/web_socket_conformance_tests/example/client_test.dart |
| pkgs/web_socket_conformance_tests/lib/src/close_local_server_vm.dart |
| pkgs/web_socket_conformance_tests/lib/src/close_local_server_web.dart |
| pkgs/web_socket_conformance_tests/lib/src/close_remote_server_vm.dart |
| pkgs/web_socket_conformance_tests/lib/src/close_remote_server_web.dart |
| pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_vm.dart |
| pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_web.dart |
| pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_vm.dart |
| pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_web.dart |
| pkgs/web_socket_conformance_tests/lib/src/echo_server_vm.dart |
| pkgs/web_socket_conformance_tests/lib/src/echo_server_web.dart |
| pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_vm.dart |
| pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_web.dart |
| pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_vm.dart |
| pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_web.dart |
| pkgs/web_socket_conformance_tests/lib/src/protocol_server_vm.dart |
| pkgs/web_socket_conformance_tests/lib/src/protocol_server_web.dart |
This check can be disabled by tagging the PR with skip-license-check.
brianquinlan
requested review from
liamappelbe and
natebosch
and removed request for
liamappelbe
November 15, 2024 19:44
natebosch
approved these changes
Nov 15, 2024
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 19, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/6bbd3d7..f8a55e4): f8a55e4b 2024-11-18 Parker Lougheed Remove unused build config (dart-lang/dartdoc#3923) fa339a10 2024-11-15 Sam Rawlins Refactor how Object and Pragma are discovered and handled (dart-lang/dartdoc#3929) http (https://github.com/dart-lang/http/compare/2f954e1..e37093f): e37093f 2024-11-15 Brian Quinlan Upgrade to `package:`objective_c` 4.0 (dart-lang/http#1406) e509abb 2024-11-14 Slava Egorov Switch browser_client.dart to use fetch (dart-lang/http#1401) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/3d1421b..8bd0fdf): 8bd0fdf 2024-11-18 Kevin Moore Fix unused param in a private ctor lint (dart-archive/yaml_edit#99) Change-Id: I12a74dc3bce629c213d26fbb6e76fc3c19a443dd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396422 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.