Update from package:unittest to package:test #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
added
the
status-blocked
|
@jirkadanek I was wondering about this, too. Talked to @nex3 Turns out this is blocked by a feature in pkg/test – dart-lang/test#330 – so we can run browser tests w/ a custom server. |
|
@nex3 @kevmoo after I land the updated browser client I plan on doing this which will obsolete this pull request. One issue is that is going to crop up is that |
|
@nex3 i believe this is obsoleted and we can close it out. Got some more tests incoming for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing this, all tests pass except the ones that rely on the /echo server. I am unsure as to what it was and where I can get it, so I made a new echo server in a separate pull request. With that pull requests, all tests pass.