Skip to content

Merge 0.11.x fixes to master #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Mar 30, 2017

No description provided.

a14n and others added 4 commits March 29, 2017 17:42
This is be more broadly compatible than the quoted version, although the
quoted version is what's described by the spec. curl and browsers send
unquoted boundaries, so we can safely assume that any server will
support them.

Closes dart-lang#61
@yjbanov yjbanov requested a review from kevmoo March 30, 2017 00:47
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@donny-dont
Copy link

@nex3 can you cherry pick everything but #59 for this and apply to master?

@yjbanov
Copy link
Contributor Author

yjbanov commented Jun 22, 2017

There's also f5adb79 that could bite some people that we might want to pull into master. Maybe it's better to close this PR and create a fresh one.

@donny-dont
Copy link

Yea whatever you think @yjbanov . After this batch of PRs land then figuring out what to about multiparts so it would be good to get any changes around that into master

@yjbanov
Copy link
Contributor Author

yjbanov commented Jun 22, 2017

Cool. Closing then. Feel free to pick up the task of merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants