Support the NSURLSession WebSocket API #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
package:cupertino_http
github-actions
bot
added
the
type-infra
github-actions
bot
removed
the
type-infra
brianquinlan
changed the title
brianquinlan
requested review from
a-siva,
aam and
liamappelbe
and removed request for
a-siva and
aam
liamappelbe
approved these changes
May 11, 2023
|
|
||
| /// Sends a single WebSocket message. | ||
| /// | ||
| /// Throws an [Error] on failure. |
There was a problem hiding this comment.
Nit: Strictly speaking, it completes the Future with an error. completeError only becomes a throw when the user awaits the Future. If they use the then method instead, they can add an onError handler.
brianquinlan
added a commit
to brianquinlan/http
that referenced
this pull request
May 16, 2023
This reverts commit 981b63b.
brianquinlan
added a commit
that referenced
this pull request
May 16, 2023
brianquinlan
added a commit
to brianquinlan/http
that referenced
this pull request
May 26, 2023
…" (dart-lang#931)" This reverts commit fb3b4be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in fixing #916