Skip to content

Adding a sentence about the semantics of >> in JavaScript compiled code #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2021
Merged

Adding a sentence about the semantics of >> in JavaScript compiled code #1448

merged 2 commits into from
Feb 15, 2021

Conversation

eernstg
Copy link
Member

@eernstg eernstg commented Feb 10, 2021

Cf. #1434.

@eernstg eernstg requested a review from lrhn February 10, 2021 12:36
@google-cla google-cla bot added the cla: yes label Feb 10, 2021
@eernstg eernstg mentioned this pull request Feb 10, 2021
Closed
eernstg
eernstg commented Feb 12, 2021
View reviewed changes
Copy link
Member Author

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Here's a response. I haven't used the phrase 'sign extension' (or any variant thereof) because that would generally refer to a different operation, but I do think the new text is a bit more readable.

@eernstg eernstg merged commit e909d79 into master Feb 15, 2021
@eernstg eernstg deleted the fix_right_shift_feb21 branch February 15, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrhn lrhn lrhn approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eernstg @lrhn