-
Notifications
You must be signed in to change notification settings - Fork 23
Logger.detached does not fire onRecord messages #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is related to hierarchicalLoggingEnabled. If the detached logger isn't a child of the root logger and hierarchicalLoggingEnabled = false then it will never reach the detached logger. Which can be a little confusing. For example this logger cannot log: Error comes from logger.dart line 183 trying to use the root logger (which has a null controller) if hierarchicalLoggingEnabled is false |
Why is this closed?
|
Maybe @astashov can comment on the intent of how Anyway, if we can agree that this should be fixed, I could take it on. I think the |
) Previously detached Loggers could log messages only if hierarchicalLoggingEnabled was true. This makes no sense to me since detached Loggers aren't part of a Logger hierarchy. Fixes https://github.com/dart-lang/logging/issues/34.
…art-archive/logging#71) Previously detached Loggers could log messages only if hierarchicalLoggingEnabled was true. This makes no sense to me since detached Loggers aren't part of a Logger hierarchy. Fixes https://github.com/dart-lang/logging/issues/34.
It would be nice to document how to catch messages :-/
The text was updated successfully, but these errors were encountered: