Skip to content

[native_toolchain_c] Tool resolver caching #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcharkes opened this issue Apr 26, 2023 · 0 comments
Open

[native_toolchain_c] Tool resolver caching #19

dcharkes opened this issue Apr 26, 2023 · 0 comments
Labels
P4 A feature or bug we're unlikely to address package:native_toolchain_c type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@dcharkes
Copy link
Collaborator

Currently, the tool resolving logic has no caching, this means that tools that are resolved relative to another tool trigger a re-resolving of that tool.

This makes tool resolving slower than needed.

However, addressing this for normal use is low priority. We'd likely only look up a single compiler and potentially an archiver per invocation of a build.dart.

A possible way to address this would be to have a ToolsCache that can be threaded through the code like the Logger.

@dcharkes dcharkes added P4 A feature or bug we're unlikely to address type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable labels Apr 26, 2023
@dcharkes dcharkes changed the title [c_compiler] Tool resolver caching [native_toolchain_c] Tool resolver caching Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 A feature or bug we're unlikely to address package:native_toolchain_c type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Development

No branches or pull requests

1 participant