You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…2102)
Bug: #1826
`package:json_syntax_generator` is only reusable if the files are self contained.
_Alternatively, we could make the generator take a config option for a JSON import. However, the downside would be that we would need copy paste the library file to multiple places._
Additionally, this PR cleans up all other uses of the `utils/json.dart` in `package:native_assets_cli`. The only remaining JSON helper is `sortOnKey()` because the asset-extension touches JSON manually and needs to sort the keys. (This could be addressed when addressing #2090.)
Currently, the asset encoding is that
type
is a special key in the map and all the other keys are the encoding.This is a bit smelly, because it means that if someone were to make a
type
in the encoding it would break.Also it leads to some weird filtering in maps:
native/pkgs/native_assets_cli/lib/src/encoded_asset.dart
Line 23 in 2dba4f5
@mkustermann suggested we should nest it.
The text was updated successfully, but these errors were encountered: