[hooks_runner] Can't run build_runner when profile folder has a space

[h3x4d3c1m4l]

When running build_runner (fvm dart run build_runner build --delete-conflicting-outputs) on my Windows 11 PC in my photobooth project, the following error gets printed:

Unexpected arguments after Dart entry point.

Usage: dart compile kernel [arguments]
[...] explanation of params which I left out because it is not relevant [...]

I did some digging and found out that it runs the following command:

"C:\Users\Some Name\fvm\versions\3.38.7\bin\cache\dart-sdk\bin\dart.exe"  compile kernel --packages=K:\Programmeren\diy-photobooth\.dart_tool\package_config.json --output=K:\Programmeren\diy-photobooth\.dart_tool\hooks_runner\objective_c\8e04c28b4433e6c12c82b92d4bcab349\hook.dill --depfile=K:\Programmeren\diy-photobooth\.dart_tool\hooks_runner\objective_c\8e04c28b4433e6c12c82b92d4bcab349\hook.dill.d "C:\Users\Some" Name\AppData\Local\Pub\Cache\hosted\pub.dev\objective_c-9.2.3\hook\build.dart

Note the username of the computer is Some Name, however it seems like this screws up the last file path in the command...

[h3x4d3c1m4l]

I just worked around the issue by setting the pub cache to a path without a space.

I'd expect (but have not confirmed) this workaround to make it a lot easier to reproduce the issue :)

[liamappelbe]

cc @dcharkes This looks like a hooks runner bug, not specific to package:objective_c

[dcharkes]

Thanks for the report @h3x4d3c1m4l 🙏

Ugh, I hate Process.runs treatment of arguments with spaces on Windows! 😆

I've tried to create a repro in #3025, but adding a space actually triggers a different error there. 🤯 The dart compile kernel command succeeds even though there's a space in the path.

@h3x4d3c1m4l since you have access to a Windows setup, could you clone this repo, and mess around with the tests in pkg/hooks_runner until you find a repro in there and then see how we should fix the Process.run invocation. (Feel free to just copypaste one of the existing tests and mess with environment to the pub get call to force a space. I don't believe a minimal repro would need a dependency on objective_c and a space in a path in the PUB_CACHE necessarily, but it's a good start.)

I'm going to mark this as relatively low prio, because I suspect adding spaces to directories is a whole can of worms based on the fact that #3025 already triggers another error. A more rigorous way of testing this would be to change all the temp directories used in tests in all packages to contain a space. 💥